Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: forbiden nested view creation #15420

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Mar 17, 2020

What problem does this PR solve?

Problem Summary:
Before this commit, nested view creation is allowed in TiDB, while select on this view brings panic. Actually, nested view creation is forbidden in MySQL.

tidb> create view v as select * from t;
Query OK, 0 rows affected (0.01 sec)                                                                                                                                    tidb> create view v2 as select * from v;
Query OK, 0 rows affected (0.02 sec)
tidb> create or replace view v as select * from v2;
Query OK, 0 rows affected (0.01 sec)
tidb> select * from v;
ERROR 2013 (HY000): Lost connection to MySQL server during query

What is changed and how it works?

What's Changed:
Check the underlying views of when creating a view. And make the error message be compatible with MySQL.

tidb> create view v as select * from t;
Query OK, 0 rows affected (0.01 sec)

tidb> create view v2 as select * from v;
Query OK, 0 rows affected (0.01 sec)

tidb> create view v3 as select * from v2;
Query OK, 0 rows affected (0.01 sec)

tidb> create or replace view v as select * from v3;
ERROR 1146 (42S02): Table 'test.v' doesn't exist

How it Works:
Forbid creating view nested.

Related changes

  • Need to cherry-pick to the release branch
    release-3.0, release-3.1, release-4.0

Check List

Tests

  • Integration test

Side effects
N/A

Release note

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 17, 2020
@XuHuaiyu XuHuaiyu requested review from a team as code owners March 17, 2020 08:23
@ghost ghost requested review from lzmhhh123, winoros, SunRunAway and wshwsh12 and removed request for a team March 17, 2020 08:23
@XuHuaiyu XuHuaiyu requested review from qw4990 and SunRunAway and removed request for lzmhhh123, winoros, SunRunAway and wshwsh12 March 17, 2020 08:23
@XuHuaiyu
Copy link
Contributor Author

/rebuild

@github-actions github-actions bot added the sig/execution SIG execution label Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #15420 into master will increase coverage by 0.5113%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #15420        +/-   ##
================================================
+ Coverage   80.3417%   80.8531%   +0.5114%     
================================================
  Files           502        502                
  Lines        133557     135735      +2178     
================================================
+ Hits         107302     109746      +2444     
+ Misses        17810      17614       -196     
+ Partials       8445       8375        -70

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We'd better add a stack depth check when performing select * from view to avoiding further stack overflow.

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020
@XuHuaiyu XuHuaiyu added needs-cherry-pick-3.0 and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 17, 2020
@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2020
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

Your auto merge job has been accepted, waiting for 15415

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0c5e581 into pingcap:master Mar 17, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

cherry pick to release-3.0 in PR #15424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants