-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serssion, server: fix the correctness of the query field in the DDL job #15435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #15435 +/- ##
===========================================
Coverage ? 80.4808%
===========================================
Files ? 502
Lines ? 134606
Branches ? 0
===========================================
Hits ? 108332
Misses ? 17813
Partials ? 8461 |
Your auto merge job has been accepted, waiting for 15415 |
/run-all-tests |
cherry pick to release-3.0 in PR #15443 |
cherry pick to release-3.1 in PR #15444 |
What problem does this PR solve?
Problem Summary:
If the DDL job's Query field is wrong, the binlog content will be wrong. We don't set the value of
sessionctx.QueryString
inExecutePreparedStmt
.What is changed and how it works?
What's Changed:
ExecutePreparedStmt
will also be set to the value ofsessionctx.QueryString
.Check List
Tests
Release note
Fix the correctness of the query field in the DDL job