Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: Skip TiFlash nodes when doing UnsafeDestroyRange and Green GC (#15505) #15516

Closed

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 20, 2020

cherry-pick #15505 to release-3.1


What problem does this PR solve?

Issue Number: close #15496

Problem Summary: GC delete range phase and (if green gc is enabled) resolve lock phase cannot successfully run when there are TiFlash nodes in the cluster.

What is changed and how it works?

What's Changed: Filters out TiFlash nodes when sending UnsafeDestroyRange and Green GC related stuff, according to the store's "engine" label. But note that it's possible to be broken when the label is incorrectly configured (see tikv/tikv#7153).

How it Works: For a TiFlash node, it uses other approach to delete dropped tables, so it's safe to skip sending UnsafeDestroyRange requests; it has only learner peers and their data must exist in TiKV, so it's safe to skip physical resolve locks for it. So in theory GC is still correct.

Related changes

  • Need to cherry-pick to the release branch
    • release-3.1 (which supports TiFlash)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Need to be test if it actually works in a TiFlash-equipped cluster. (Help wanted)

Side effects

Release note

(I'm not sure if this is needed since it's related to TiFlash)

  • Fixes the issue that GC may not work in a cluster that has TiFlash

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 20, 2020

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants