planner: don't reset optFlag when build DataSource from View #15547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis0407
added
type/bugfix
ghost
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15547 +/- ##
================================================
+ Coverage 80.4311% 80.4564% +0.0253%
================================================
Files 502 502
Lines 134106 134249 +143
================================================
+ Hits 107863 108012 +149
- Misses 17785 17788 +3
+ Partials 8458 8449 -9 |
XuHuaiyu
added
status/can-merge
|
/run-all-tests |
|
@francis0407 merge failed. |
|
/rebuild |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 22, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15559 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 22, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15560 |
sre-bot
added a commit
that referenced
this pull request
Mar 24, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15546
Problem Summary:
When build DataSource from View, we may reset the optFlag which causes bugs like #15546.
What is changed and how it works?
What's Changed:
Use
optFlag = optFlag | flagPrunColumnsinstead ofoptFlag = flagPrunColumns.How it Works:
Related changes
Check List
Tests
Release note
fix panic when select from view.