-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix incorrect result of logical operators for vectorized expression evaluation #15891
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15891 +/- ##
===========================================
Coverage 80.5687% 80.5687%
===========================================
Files 505 505
Lines 135467 135467
===========================================
Hits 109144 109144
Misses 17845 17845
Partials 8478 8478 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@Reminiscent merge failed. |
/run-unit-test |
/merge |
/run-all-tests |
@Reminiscent merge failed. |
/run-integration-common-test |
/merge |
/run-all-tests |
…expression evaluation (pingcap#15891)
cherry pick to release-4.0 in PR #15907 |
What problem does this PR solve?
Related to: #PR12173 #issue15718
What is changed and how it works?
Apply changes from #PR12173 to vectorized expression evaluation.
Fix the wrong bitwise operations.
Check List
Tests