planner: add warning when use_index_merge hint's index names are invalid #15960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis0407
added
type/bugfix
ghost
requested review from
lzmhhh123
added
status/can-merge
|
/merge |
Codecov Report
@@ Coverage Diff @@
## master #15960 +/- ##
===========================================
Coverage 80.9001% 80.9001%
===========================================
Files 506 506
Lines 137577 137577
===========================================
Hits 111300 111300
Misses 17784 17784
Partials 8493 8493 |
|
/run-all-tests |
|
@francis0407 merge failed. |
|
/merge |
|
/run-all-tests |
|
@francis0407 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 15710 |
|
/run-all-tests |
|
@francis0407 merge failed. |
|
/merge |
|
/run-all-tests |
|
@francis0407 merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #16036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Add warning when
use_index_merge(table, index)hint contains invalid index name.What is changed and how it works?
How it Works:
check the index names when add hints into DataSource.
Related changes
Check List
Tests
Side effects