Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: set TblInfo correctly when fast analyze PK #16005

Merged
merged 3 commits into from
Apr 4, 2020

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Apr 2, 2020

What problem does this PR solve?

Issue Number: close #15993

Problem Summary:

What is changed and how it works?

TblInfo is not set when buildAnalyzeIndex and the index is handle.

Proposal: xxx

What's Changed:
Set TblInfo correctly.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Apr 2, 2020
@XuHuaiyu XuHuaiyu requested review from winoros and lzmhhh123 April 2, 2020 06:47
@XuHuaiyu XuHuaiyu requested review from a team as code owners April 2, 2020 06:47
@ghost ghost requested review from wshwsh12 and removed request for a team April 2, 2020 06:47
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Apr 2, 2020
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Apr 2, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #16005 into master will increase coverage by 0.0919%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             master    #16005        +/-   ##
===============================================
+ Coverage   80.4491%   80.541%   +0.0919%     
===============================================
  Files           506       506                
  Lines        135426    135331        -95     
===============================================
+ Hits         108949    108997        +48     
+ Misses        17971     17838       -133     
+ Partials       8506      8496        -10

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2020
@zz-jason zz-jason removed request for winoros and wshwsh12 April 4, 2020 07:24
@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-3.0 in PR #16079

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-3.1 in PR #16080

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-4.0 in PR #16081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fast ANALYZE TABLE on INDEX PRIMARY causes an error "analyze worker panic"
4 participants