Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix partition selection on hash partitioned table #16070

Merged

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

See the test case.

What is changed and how it works?

Remove redundancy code and get back the missing code

https://github.com/pingcap/tidb/compare/release-3.0...tiancaiamao:partition-selection-on-hash?expand=1#diff-0411f48b4045359c9f116ef6a779c3efR736-R740

This bug exists on branch 3.0, the master branch is fine.

Tests

  • Unit test

@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat @jackysp

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2020
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 4, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

@tiancaiamao merge failed.

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/fix-16070

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1030

@tiancaiamao tiancaiamao closed this Apr 4, 2020
@tiancaiamao tiancaiamao reopened this Apr 4, 2020
@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1030

@tiancaiamao
Copy link
Contributor Author

/rebuild tidb-test=pr/1030

@tiancaiamao
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/1030

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2020
@zz-jason zz-jason merged commit 07fe918 into pingcap:release-3.0 Apr 4, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-3.1 in PR #16076

@tiancaiamao tiancaiamao deleted the partition-selection-on-hash branch April 13, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants