planner: fix different err msg from MySQL when group by window function #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #16134 +/- ##
===========================================
Coverage 80.6129% 80.6129%
===========================================
Files 504 504
Lines 135936 135936
===========================================
Hits 109582 109582
Misses 17880 17880
Partials 8474 8474 |
eurekaka
added
sig/planner
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@time-and-fate merge failed. |
|
/merge |
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-3.0 in PR #16161 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-3.1 in PR #16162 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-4.0 in PR #16165 |
time-and-fate
added a commit
to time-and-fate/tidb
that referenced
this pull request
Apr 15, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 26, 2020
zz-jason
pushed a commit
that referenced
this pull request
May 14, 2020
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
sre-bot
pushed a commit
that referenced
this pull request
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11518
Problem Summary: When GROUP BY is followed by a number in a select stmt and this number correspond to a window function in select fields, TiDB prints a different error message from MySQL.
What is changed and how it works?
What's Changed: When dealing with ast.PositionExpr in gbyResolver's Leave() method, we check if it's a ast.WindowFuncExpr. If so, ErrWrongGroupField will occur, which is expected.
Check List
Tests
Release Note