util: fix wrong range when building from string column is true. #16135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
francis0407
and removed request for
a team
wshwsh12
added
type/bugfix
winoros
reviewed
Apr 14, 2020
I have a try. Decimal and float will get a right range, beacuse decimal and float are comparable to Int. |
Codecov Report
@@ Coverage Diff @@
## master #16135 +/- ##
================================================
+ Coverage 80.4113% 80.4568% +0.0455%
================================================
Files 506 506
Lines 136625 136805 +180
================================================
+ Hits 109862 110069 +207
+ Misses 18192 18178 -14
+ Partials 8571 8558 -13 |
|
/run-all-tests |
|
@wshwsh12 merge failed. |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16552 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #16553 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #16554 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 17, 2020
|
cherry pick to release-4.0 in PR #16555 |
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15990
Problem Summary: Using a column both in a string comparison and as a boolean yields an incorrect result.
What is changed and how it works?
What's Changed: Build a range from string column wrongly. So I change the endpoint from int 0 to string ''
How it Works:
Related changes
Check List
Tests
Side effects
Release note
Fix the wrong behavior when string column in
wherestmt to check True/False.