Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column (#12230) (#15861) #16247

Merged
merged 5 commits into from
Apr 14, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #12230
#15861

…nd more than 2 index contain auto_increment_column (pingcap#12230)

Signed-off-by: crazycs520 <crazycs520@gmail.com>
…nd the auto_increment column is primary key (pingcap#15861)

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

ddl/index.go Outdated Show resolved Hide resolved
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2020

Sorry @crazycs520, you don't have permission to trigger auto merge event on this branch.

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 13, 2020
@zz-jason
Copy link
Member

/merge

@bb7133
Copy link
Member

bb7133 commented Apr 14, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16014

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

@crazycs520 merge failed.

@crazycs520
Copy link
Contributor Author

/run-unit-test

@bb7133 bb7133 merged commit fa5d997 into pingcap:release-2.1 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants