Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, executor: forbid truncate view #16251

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Apr 9, 2020

What problem does this PR solve?

Issue Number: close #16250

What is changed and how it works?

Proposal: xxx

What's Changed:
Forbid truncate view.

How it Works:
Return an error when truncate view.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. needs-cherry-pick-3.0 sig/sql-infra SIG: SQL Infra labels Apr 9, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner April 9, 2020 12:57
@ghost ghost requested review from qw4990 and removed request for a team April 9, 2020 12:57
@XuHuaiyu XuHuaiyu requested a review from SunRunAway April 9, 2020 12:57
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #16251 into master will increase coverage by 0.0647%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #16251        +/-   ##
================================================
+ Coverage   80.4221%   80.4869%   +0.0647%     
================================================
  Files           506        506                
  Lines        136690     136990       +300     
================================================
+ Hits         109929     110259       +330     
+ Misses        18197      18178        -19     
+ Partials       8564       8553        -11     

@github-actions github-actions bot added the sig/execution SIG execution label Apr 9, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16094, 16344

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

@XuHuaiyu merge failed.

@XuHuaiyu
Copy link
Contributor Author

/run-integration-copr-test

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/run-integration-copr-test

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@XuHuaiyu XuHuaiyu merged commit 0ec8d33 into pingcap:master Apr 15, 2020
@XuHuaiyu XuHuaiyu deleted the truncate_view branch April 15, 2020 10:28
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-3.0 in PR #16420

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-3.1 in PR #16421

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #16422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truncate table view_name should return an error
4 participants