expression: fix panic of explain for connection when plan cache is enabled (#16206)
#16285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/execution
ghost
requested a review
from 
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16206 to release-4.0
What problem does this PR solve?
Issue Number: close #16110
Problem Summary:
explain for connectioncauses panic.What is changed and how it works?
What's Changed:
If plan cache is enabled,
Constantin plan may refer toParamMarker, which would be reset if other queries are executed, soexplain for connectionwould panic when trying to accessPreapredParams.How it Works:
If we are in
explain for connection, just use the pre-evaluated type and datum of theConstant.Related changes
Check List
Tests
Side effects
N/A
Release note