executor: support 'SET CONFIG' syntax to change configs of TiKV/PD instances #16480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
francis0407 and
wshwsh12
and removed request for
francis0407 and
a team
SunRunAway
reviewed
Apr 21, 2020
SunRunAway
reviewed
Apr 21, 2020
SunRunAway
reviewed
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #16480 +/- ##
===========================================
Coverage 80.6207% 80.6207%
===========================================
Files 507 507
Lines 138256 138256
===========================================
Hits 111463 111463
Misses 18215 18215
Partials 8578 8578 |
|
/rebuild |
SunRunAway
added
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Apr 27, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16479
Problem Summary: support
SET CONFIGsyntax to change configs of TiKV/PD instancesWhat is changed and how it works?
When processing
SET CONFIG, theSetConfigExecsends commands toTiKVandPDto let them update their configs according to their HTTP API.If it is failed to update some instances' configs, you can use
SHOW WARNINGSto get these errors.Check List
Tests