-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix unexpected error when setting collate for database (#16283) #16540
*: fix unexpected error when setting collate for database (#16283) #16540
Conversation
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failed test case:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@sre-bot merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@sre-bot merge failed. |
cherry-pick #16283 to release-4.0
What problem does this PR solve?
Problem Summary:
This PR tries to fix the two problems related to the charset and collate when creating a schema:
and
What is changed and how it works?
What's Changed:
Resolve charset and collation in
CreateSchema()
function in ddl_api.goSome charset/collation functions are also refactored to make the logic clear enough.
How it Works:
Related changes
Check List
Tests
Side effects
Release note
CREATE SCHEMA
syntax, fix missingCOLLATE
part forSHOW CREATE SCHEMA
syntax.