expression: split isTrue and isFalse expression sig (#16542) #16630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/execution
ghost
requested a review
from 
|
/run-all-tests |
|
wait for tikv#7567 |
zz-jason
reviewed
Apr 22, 2020
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-integration-copr-test |
SunRunAway
approved these changes
Apr 24, 2020
SunRunAway
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
@zz-jason Please help me to merge this PR. Thanks! |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16542 to release-4.0
What problem does this PR solve?
Close: #15718
Close: #15987
Close: #16501
Close: #16716
Related PR: #12173 #15926 tikv#7532
The reason for the above error is that the variable keepNull in the expression
isTrueandisFalseis not pushed down correctly.After an offline discussion with @XuHuaiyu @SunRunAway @breeswish , we decided to eliminate the
keepNullvariable by splitting theisTrueandisFalseexpression sig to solve this problem.What is changed and how it works?
Split the
isTrueandisFalseexpression sig. When thekeepNull = true, we setsetPbCode = tipb.ScalarFuncSig_XXXIsTrueWithNull. When thekeepNull = false, we setsetPbCode = tipb.ScalarFuncSig_XXXIsTrue.So we can don't need to push down the
keepNullvariable.Check List
Tests