Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: avoid Order By constant expression error when plan cache is enabled (#16261) #16675

Merged
merged 5 commits into from
Apr 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #16261 to release-4.0


What problem does this PR solve?

Issue Number: close #16203

Problem Summary:

Error is reported for order by rand() when plan cache is enabled.

What is changed and how it works?

What's Changed:

  • remove Rand / Sysdate / UUID from DeferredFunctions, because they should not be folded into constant according to unFoldableFunctions, otherwise, they would be converted to a Constant with DeferredExpr in funcCallToExpression. This change makes the behavior regarding these functions consistent when plan cache is enabled / disabled.

  • check if the order by items can be treated as constants during execution using a new function, instead of IsMutableEffectsExpr, which is specifically designed for de-duplicating expressions.

How it Works:

Related previous PRs for this change:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

@sre-bot sre-bot requested review from a team as code owners April 21, 2020 12:08
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2020
@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor

/run-sqllogic-test-2

@eurekaka
Copy link
Contributor

/run-integration-common-test
/run-sqllogic-test-1

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

Your auto merge job has been accepted, waiting for:

  • 16739
  • 15905
  • 16714
  • 16559
  • 16414
  • 16564

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 77e01b6 into pingcap:release-4.0 Apr 23, 2020
@crazycs520 crazycs520 modified the milestones: v4.0.0-rc.2, v4.0.0-rc.1 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants