*: fix lost index bug of insert on duplicate key update (#16672) #16689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue pingcap#16669 When check the untouched index, we should also check the memory-buffer in the session too.
|
/run-all-tests |
sre-bot
added
sig/execution
|
LGTM |
|
/run-common-test |
|
LGTM |
|
/merge |
coocood
approved these changes
Apr 22, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16672 to release-4.0
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
Fix issue #16669
What is changed and how it works?
When check the untouched index, should also check the
memory-bufferin the session too.Related changes
Check List
Tests
Side effects
Release note