Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "expression: support NO_ZERO_DATE sql_mode" #16740

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Revert "expression: support NO_ZERO_DATE sql_mode" #16740

merged 2 commits into from
Apr 23, 2020

Conversation

wjhuang2016
Copy link
Member

Reverts #16053

@wjhuang2016 wjhuang2016 requested a review from a team as a code owner April 22, 2020 18:34
@ghost ghost requested review from wshwsh12 and removed request for a team April 22, 2020 18:35
@wjhuang2016
Copy link
Member Author

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Apr 23, 2020

Why we need to revert it?

@wjhuang2016
Copy link
Member Author

Why we need to revert it?

That PR will cause common-test to fail.

@bb7133
Copy link
Member

bb7133 commented Apr 23, 2020

I see... so sad.

bb7133
bb7133 reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 23, 2020
AilinKid
AilinKid approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2020
@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit 242ce93 into master Apr 23, 2020
@zimulala zimulala deleted the revert-16053-fix_no_zero_date branch April 23, 2020 06:00
wjhuang2016 added a commit that referenced this pull request May 11, 2020
@wjhuang2016
Revert "Revert "expression: support NO_ZERO_DATE sql_mode" (#16740)"
fbf4bb2 
This reverts commit 242ce93.
@wjhuang2016 wjhuang2016 mentioned this pull request May 11, 2020
Closed
@ghost ghost mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@bb7133 bb7133 bb7133 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjhuang2016 @winkyao @bb7133 @sre-bot @AilinKid