tikv: keep using origin goroutine when doing retry in commit phase #16849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-mybatis-test |
Codecov Report
@@ Coverage Diff @@
## master #16849 +/- ##
===========================================
Coverage 80.5357% 80.5357%
===========================================
Files 507 507
Lines 138793 138793
===========================================
Hits 111778 111778
Misses 18337 18337
Partials 8678 8678 |
|
in large-txn test: |
coocood
reviewed
Apr 27, 2020
store/tikv/2pc.go
Outdated
| @@ -46,11 +46,12 @@ import ( | |||
| type twoPhaseCommitAction interface { | |||
| handleSingleBatch(*twoPhaseCommitter, *Backoffer, batchMutations) error | |||
| tiKVTxnRegionsNumHistogram() prometheus.Observer | |||
| inRetry() bool | |||
There was a problem hiding this comment.
inRetryCommit to be exact?
Maybe we don't need to add this method to the interface.
store/tikv/2pc.go
Outdated
| @@ -527,7 +548,7 @@ func (c *twoPhaseCommitter) doActionOnBatches(bo *Backoffer, action twoPhaseComm | |||
| return nil | |||
| } | |||
|
|
|||
| if len(batches) == 1 { | |||
| if len(batches) == 1 || action.inRetry() { | |||
There was a problem hiding this comment.
Why only handle the first batch?
Other batches are left uncommitted?
|
/run-all-tests |
|
LGTM |
1 similar comment
|
LGTM |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@lysu merge failed. |
|
/run-integration-copr-test |
|
cherry pick to release-4.0 in PR #16876 |
sre-bot
added a commit
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15995
Problem Summary:
make goroutine count in retry commit-phase can be controlled by
committer-concurrencyWhat is changed and how it works?
Proposal: xxx
What's Changed:
no longer fork new goroutine when retry
How it Works:
no longer fork new goroutine when retry
Related changes
Check List
Tests
Side effects
Release note
make goroutine count in retry commit-phase can be controlled by
committer-concurrencyThis change is