Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: make handshake packet read/write error log as debug (#16877) #16881

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 28, 2020

cherry-pick #16877 to release-4.0


What problem does this PR solve?

Problem Summary:

many users complain handshake info log

What is changed and how it works?

Proposal: xxx

What's Changed:

let them be DEBUG level, and we can turn log level to debug when RD want to see problem dynamic.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • n/a

Release note

let handshake packet read/write error log as debug


This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu removed this from the v4.0.0-rc.1 milestone Apr 28, 2020
@lysu lysu removed the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 28, 2020
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 28, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

@sre-bot merge failed.

@ngaut ngaut merged commit b0fe762 into pingcap:release-4.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants