Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, types: copy enum/set instead of refer th... (#16858) #16890

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 28, 2020

cherry-pick #16858 to release-3.0


What problem does this PR solve?

Issue Number: close #16854

Problem Summary:

What is changed and how it works?

What's Changed:
Copy enum/set instead of referring the underlying data in GetMysqlEnum and GetMysqlSet

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

  • Performance regression
    • Consumes more MEM

Release note

  • Fix unstable result when select distinct enum column or set column.

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 28, 2020
@zz-jason
Copy link
Member

/run-integration-ddl-test

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

@sre-bot merge failed.

@zz-jason zz-jason changed the title executor, types: copy enum/set instead of refer the underlying data (#16858) executor, types: copy enum/set instead of refer th... (#16858) Apr 28, 2020
@ngaut ngaut merged commit 49de760 into pingcap:release-3.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants