config: remove the special limit of txn-total-size-limit when binlog enabled #16919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabled Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
added
the
release-note
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@jackysp merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #16919 +/- ##
================================================
+ Coverage 80.0910% 80.1423% +0.0512%
================================================
Files 508 508
Lines 138149 138269 +120
================================================
+ Hits 110645 110812 +167
+ Misses 18565 18525 -40
+ Partials 8939 8932 -7 |
|
/run-integration-copr-test |
|
/merge |
|
cherry pick to release-4.0 in PR #16941 |
sre-bot
added a commit
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
We've tested the big transaction when binlog enabled, pump, and drainer can handle 10GB transactions. But with Kafka as an arbiter or some other usage of binlog, it could only handle 1GB transactions, because Kafka has its own max message limit.
What is changed and how it works?
Proposal: xxx
What's Changed:
We could not know if there is a Kafka cluster using in the binlog replication. So we remove the limitation and keep the warnings of txn-total-size-limit usage.
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
There is an internal doc for it.
Release note
Remove the special limit of txn-total-size-limit when binlog enabled.