-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix unique index point get read with delete first (#16965) #16991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
ghost
requested a review
from SunRunAway
May 6, 2020 11:28
sre-bot
added
sig/execution
SIG execution
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
May 6, 2020
/run-check_release_note |
/rebuild |
jackysp
reviewed
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lzmhhh123
approved these changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XuHuaiyu
approved these changes
May 7, 2020
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 7, 2020
/run-all-tests |
@sre-bot merge failed. |
/rebuild |
1 similar comment
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16965 to release-4.0
What problem does this PR solve?
Problem Summary:
PointGet
executor should process deleted index record with zero value lengthWhat is changed and how it works?
What's Changed:
Check index value got with zero-length
How it Works:
Related changes
Check List
Tests
Side effects
Release note
PointGet
query after thedelete
operation