tikv: don't collapse batch resolve locks #17025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
youjiali1995
added
type/bugfix
|
How did you find this bug? @youjiali1995 |
Green GC test always fails after upgrading dependency of it to latest release-4.0. |
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
force-pushed
the
fix-collapse-resolve-lock
branch
from
40757ed
to
ff0d815
Compare
Codecov Report
@@ Coverage Diff @@
## master #17025 +/- ##
================================================
- Coverage 80.0804% 79.9815% -0.0989%
================================================
Files 510 510
Lines 139305 138797 -508
================================================
- Hits 111556 111012 -544
- Misses 18788 18817 +29
- Partials 8961 8968 +7 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
Does this affect data correctness? If so, it will affect legacy resolvelocks mode too |
Yes. But It is not released in any version. @MyonKeminta |
|
/run-unit-test |
sre-bot
added a commit
to sre-bot/tidb
that referenced
this pull request
May 8, 2020
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17033 |
jackysp
pushed a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Problem Summary:
#16838 collapses the same resolve lock requests. However, it uses
RegionId + StartVersionas the key:tidb/store/tikv/client_collapse.go
Line 61 in e3e51b4
When doing GC, GC worker calls
BatchResolveLockswhoseStartVersionis always 0. It results in unexpected collapses:tidb/store/tikv/lock_resolver.go
Line 241 in e3e51b4
What is changed and how it works?
What's Changed:
Don't collapse batch resolve locks.
Related changes
Check List
Tests
Side effects
Release note