Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix grafana script of QPS by instance and type #17073

Merged
merged 2 commits into from
May 12, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 9, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #17071

Problem Summary: QPS by instance and type are wrong.

What is changed and how it works?

Proposal: xxx

What's Changed: Fix them.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    monitor test
    image

Release note

  • Fix the display of QPS by instance and type of TiDB Summary Dashboard in Grafana.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp
Copy link
Member Author

jackysp commented May 9, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented May 9, 2020

Visit the grafana server at: http://172.16.5.5:31179, it will last for 5 hours

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #17073 into master will decrease coverage by 0.0994%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #17073        +/-   ##
================================================
- Coverage   80.0313%   79.9319%   -0.0995%     
================================================
  Files           510        510                
  Lines        139033     138982        -51     
================================================
- Hits         111270     111091       -179     
- Misses        18808      18888        +80     
- Partials       8955       9003        +48     

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp requested a review from wshwsh12 May 12, 2020 01:41
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels May 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

cherry pick to release-4.0 in PR #17105

@jackysp jackysp deleted the fix_qps_metrics branch November 25, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QPS by instance in metrics display wrong
4 participants