Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch_coprocessor: change config for batch_coprocessor's timeout (#17135) #17161

Merged
merged 2 commits into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17135 to release-4.0


What problem does this PR solve?

  • TiFlash always do heavy computation, so timeout shoule be large enough. This PR set it 60min, which can cover most cases.
  • Secondly, when timeout happens, tiflash should not retry, because it must be a logic error but not eviroument error (like io error)

What is changed and how it works?

What's Changed:
Timeout config is larger and on send fail will not retry for canceled error

Tests

Test is implemented in TiFlash Side

Release note

  • fix bugs of tikv server timeout when tidb_allow_batch_cop is enabled.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT2 Indicates that a PR has LGTM 2. label May 13, 2020
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 77d8f23 into pingcap:release-4.0 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/coprocessor status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants