Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: create linear hash partition and sub partition table as normal table (#16706) #17197

Merged
merged 5 commits into from
May 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 14, 2020

cherry-pick #16706 to release-4.0


What problem does this PR solve?

Problem Summary:

We do not support linear hash partitioned table and sub partition option.
It's better to create the table as normal table, rather than ignore those option.

What is changed and how it works?

Create as normal table in those cases.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

https://github.com/pingcap/automated-tests/pull/191

Side effects

  • Breaking backward compatibility

The behavior slightly chage, but should not affect trouble the user too much.

Release note

  • Prior to TiDB 4.0, create table with sub-partition or linear hash options are treated as partition table with the options ignored. Now those cases are created as normal tables.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot sre-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels May 14, 2020
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 14, 2020
@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1057

@tiancaiamao
Copy link
Contributor

PTAL @jacksp @zimulala

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label May 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

@sre-bot merge failed.

@tiancaiamao
Copy link
Contributor

/rebuild

@zimulala
Copy link
Contributor

@tiancaiamao We merged https://github.com/pingcap/tidb-test/pull/1057, but don't merge this PR.
WeChatWorkScreenshot_ebce5cb0-4d7b-443a-acdd-e4ae26e57daf

Please merge this PR as soon as possible.

@zimulala
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

Sorry @zimulala, you don't have permission to trigger auto merge event on this branch.

@zimulala
Copy link
Contributor

@tiancaiamao Maybe we need revert #17197.

@shuke987 shuke987 merged commit 7008e17 into pingcap:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants