-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: create linear hash partition and sub partition table as normal table (#16706) #17197
ddl: create linear hash partition and sub partition table as normal table (#16706) #17197
Conversation
/run-all-tests |
/run-all-tests tidb-test=pr/1057 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
@sre-bot merge failed. |
/rebuild |
@tiancaiamao We merged https://github.com/pingcap/tidb-test/pull/1057, but don't merge this PR. Please merge this PR as soon as possible. |
/merge |
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. |
@tiancaiamao Maybe we need revert #17197. |
cherry-pick #16706 to release-4.0
What problem does this PR solve?
Problem Summary:
We do not support
linear hash
partitioned table andsub partition
option.It's better to create the table as normal table, rather than ignore those option.
What is changed and how it works?
Create as normal table in those cases.
Related changes
Check List
Tests
https://github.com/pingcap/automated-tests/pull/191
Side effects
The behavior slightly chage, but should not affect trouble the user too much.
Release note