tikv: fix panic after sending fail with ambiguous errors #17211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hicqu PTAL, and maybe need help to recheck tikv's impl |
lysu
added
component/tikv
needs-cherry-pick-3.0
type/bugfix
|
ref tikv/tikv#7324 and #15943 - - |
hicqu
approved these changes
May 18, 2020
|
@jackysp need a approve |
jackysp
approved these changes
May 25, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17211 +/- ##
===========================================
Coverage 79.8423% 79.8423%
===========================================
Files 520 520
Lines 139897 139897
===========================================
Hits 111697 111697
Misses 19236 19236
Partials 8964 8964 |
|
cherry pick to release-3.0 in PR #17378 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 25, 2020
|
cherry pick to release-3.1 in PR #17379 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 25, 2020
|
cherry pick to release-4.0 in PR #17380 |
jebter
added a commit
that referenced
this pull request
May 25, 2020
sre-bot
added a commit
that referenced
this pull request
Jun 8, 2020
sre-bot
added a commit
that referenced
this pull request
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17201
Problem Summary:
batch client cleans up request map after sending fail, but tikv have the chance to receive requests when some ambiguous error happened.
and we should get panic when tikv make responses to those ambiguous requests now
What is changed and how it works?
Proposal: xxx
What's Changed:
log instead of panic
Related changes
Check List
Tests
Side effects
Release note
This change is