Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix unsecessfully set the isolation read engines #17258

Merged

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented May 18, 2020

What problem does this PR solve?

Issue Number: close #17257

What is changed and how it works?

What's Changed: fix the incorrectly init for session variables.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Fix the problem when isolation read engines in tidb toml do not take effort.

@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2020

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #17258 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17258   +/-   ##
===========================================
  Coverage   79.8200%   79.8200%           
===========================================
  Files           520        520           
  Lines        139733     139733           
===========================================
  Hits         111535     111535           
  Misses        19233      19233           
  Partials       8965       8965           

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label May 20, 2020
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 merged commit 0d33a84 into pingcap:master May 20, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix-incorrect-set-sess-var branch May 20, 2020 11:54
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 20, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-3.1 in PR #17321

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-4.0 in PR #17322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolation read don't take effort after reboot tidb-server
4 participants