Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/admin: support admin recover index on the partition table (#17195) #17317

Merged
merged 3 commits into from
May 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 20, 2020

cherry-pick #17195 to release-4.0


What problem does this PR solve?

Before this PR, admin recover index won't take effect on partition table.

What is changed and how it works?

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Support admin recover index on the partition table.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner May 20, 2020 09:16
@ghost ghost requested a review from qw4990 May 20, 2020 09:16
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@ghost ghost removed their request for review May 20, 2020 09:16
@sre-bot sre-bot added sig/execution SIG execution component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 20, 2020
@sre-bot sre-bot requested review from wshwsh12 and XuHuaiyu May 20, 2020 09:16
@sre-bot sre-bot added this to the v4.0.0-ga milestone May 20, 2020
@XuHuaiyu
Copy link
Contributor

@crazycs520 Please resolve the conflicts

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 21, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

@sre-bot merge failed.

@jebter
Copy link

jebter commented May 21, 2020

/run-unit-test

@jebter jebter merged commit d514a17 into pingcap:release-4.0 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants