-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/admin: support admin recover index on the partition table (#17195) #17317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
ghost
requested a review
from qw4990
May 20, 2020 09:16
/run-all-tests |
ghost
removed their request for review
May 20, 2020 09:16
sre-bot
added
sig/execution
SIG execution
component/util
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
May 20, 2020
@crazycs520 Please resolve the conflicts |
/run-all-tests |
XuHuaiyu
reviewed
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
approved these changes
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 21, 2020
/run-all-tests |
@sre-bot merge failed. |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/util
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17195 to release-4.0
What problem does this PR solve?
Before this PR,
admin recover index
won't take effect on partition table.What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note