Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong agg function when agg push down union (#17022) #17326

Closed

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 20, 2020

cherry-pick #17022 to release-3.0


What problem does this PR solve?

Issue Number: close #16861

Problem Summary: when the aggregation is pushed down the union, we should append the first row for group by items.

What is changed and how it works?

What's Changed: append the first row when the partial aggregation is built under the union.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

Fix the panic when aggregation push down enable on the partition table.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution sig/planner SIG: Planner priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels May 20, 2020
@sre-bot sre-bot added this to the v3.0.15 milestone May 20, 2020
@lzmhhh123
Copy link
Contributor

Not a problem in release-3.0

@lzmhhh123 lzmhhh123 closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants