Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong agg function when agg push down union (#17022) #17328

Merged
merged 3 commits into from
May 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 20, 2020

cherry-pick #17022 to release-4.0


What problem does this PR solve?

Issue Number: close #16861

Problem Summary: when the aggregation is pushed down the union, we should append the first row for group by items.

What is changed and how it works?

What's Changed: append the first row when the partial aggregation is built under the union.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

Fix the panic when aggregation push down enable on the partition table.

@sre-bot sre-bot requested review from a team as code owners May 20, 2020 13:53
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution sig/planner SIG: Planner priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 20, 2020
@ghost ghost requested review from SunRunAway and lzmhhh123 and removed request for a team May 20, 2020 13:54
@sre-bot sre-bot added this to the v4.0.0-ga milestone May 20, 2020
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 21, 2020

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@XuHuaiyu
Copy link
Contributor

@jebter can merge

@jebter
Copy link

jebter commented May 21, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7e33460 into pingcap:release-4.0 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants