planner: check required order property for enforced stream aggregation #17338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
ghost
requested review from
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17338 +/- ##
================================================
- Coverage 80.2052% 79.8625% -0.3427%
================================================
Files 520 520
Lines 141477 140013 -1464
================================================
- Hits 113472 111818 -1654
- Misses 19088 19226 +138
- Partials 8917 8969 +52 |
eurekaka
added
status/all-tests-passed
status/LGT1
SunRunAway
added
status/can-merge
|
/run-all-tests |
|
@eurekaka merge failed. |
|
CI failed because of #17146 |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.1 in PR #17346 |
|
cherry pick to release-4.0 in PR #17347 |
|
Is this bug affected with v3.0? @eurekaka |
No. |
eurekaka
added a commit
to sre-bot/tidb
that referenced
this pull request
May 22, 2020
eurekaka
added a commit
to sre-bot/tidb
that referenced
this pull request
May 22, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot
added a commit
that referenced
this pull request
May 22, 2020
sre-bot
added a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17325
Problem Summary:
Wrong result for enforced stream aggregation when order is required.
What is changed and how it works?
What's Changed:
Check if the enforced stream aggregation can satisfy the required order property.
Related changes
Check List
Tests
Side effects
N/A
Release note