planner: fix wrong index merge join plan for join key is not the prefix of index (#16894) #17365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/execution
ghost
removed their request for review
lzmhhh123
added
the
priority/release-blocker
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16894 to release-4.0
What problem does this PR solve?
Issue Number: close #16887
Problem Summary: consider the situations in issue.
The problem is caused by the planner, the join keys of index merge join must strictly meet the prefix of the inner index. In this case, the join key is:
admin_role_has_permissions.role_idAnd index used:
(permission_id, role_id)The data read from the inner to keep order is not actually ordered by the join key, which causes the index merge join to produce the wrong join result.
What is changed and how it works?
What's Changed: when the join keys do not strictly meet the prefix of the inner index. Don't generate the index merge join plan.
Related changes
Check List
Tests
Side effects
Release note
Fix planner incorrectly choose index merge join in some cases.