plancodec: add test for plan id to avoid change the plan id. #17385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
crazycs520
added
type/enhancement
ghost
requested review from
crazycs520
commented
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #17385 +/- ##
===========================================
Coverage 79.4458% 79.4458%
===========================================
Files 520 520
Lines 139957 139957
===========================================
Hits 111190 111190
Misses 19798 19798
Partials 8969 8969 |
|
/run-all-tests |
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
LittleFall
approved these changes
Jun 1, 2020
|
lgtm |
winoros
approved these changes
Jun 1, 2020
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
#15507 remove a plan that causes the rest plan ID was changed, It was unexpected.
iotaWhat is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note