Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: fix infinite follower/learner retry when network partition only between leader and follower/learner #17441

Merged
merged 1 commit into from
May 27, 2020
Merged

tikv: fix infinite follower/learner retry when network partition only between leader and follower/learner #17441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions store/tikv/region_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,11 @@ func (c *RegionCache) OnSendFail(bo *Backoffer, ctx *RPCContext, scheduleReload
rs := r.getStore()
if err != nil {
s := rs.stores[ctx.PeerIdx]
followerRead := int(rs.workTiKVIdx) != ctx.PeerIdx

// send fail but store is reachable, keep retry current peer.
if s.requestLiveness(bo) == reachable {
// send fail but store is reachable, keep retry current peer for replica leader request.
// but we still need switch peer for follower-read or learner-read(i.e. tiflash)
if ctx.Store.storeType == kv.TiKV && !followerRead && s.requestLiveness(bo) == reachable {
return
}

Expand Down