Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix the issue that max_execution_time hint doesn't work if it exceed the expensive-slow-log-threshold #17464

Closed
wants to merge 1 commit into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 28, 2020

What problem does this PR solve?

Issue Number: close #17393

Problem Summary: max_execution_time hint doesn't work if it exceed the expensive-slow-log-threshold

What is changed and how it works?

WIP

Check List

Tests

  • Unit test

Release note

  • fix the issue that max_execution_time hint doesn't work if it exceed the expensive-slow-log-threshold

@qw4990 qw4990 requested a review from XuHuaiyu May 28, 2020 02:59
@qw4990 qw4990 requested a review from a team as a code owner May 28, 2020 02:59
@ghost ghost removed their request for review May 28, 2020 02:59
@qw4990
Copy link
Contributor Author

qw4990 commented May 28, 2020

I have no idea about how to add some unit tests to test this PR, could you give me some suggestions? @XuHuaiyu

@qw4990
Copy link
Contributor Author

qw4990 commented May 28, 2020

Close due to be duplicated with #17359.

@qw4990 qw4990 closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_execution_time hint doesn't work if it exceed the expensive-slow-log-threshold
1 participant