-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add no register API for using TiDB as a library #17513
Merged
+22
−7
Merged
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1dd3c2c
domain,session: add NoRegister entry
1c3280a
Merge branch 'master' of https://github.com/pingcap/tidb into no-regi…
e3010e8
Merge branch 'master' of https://github.com/pingcap/tidb into no-regi…
0179b99
session: run fmt
58977ab
Merge branch 'master' into no-register
YuJuncen ee8aa92
Merge branch 'master' of https://github.com/pingcap/tidb into no-regi…
90c3b95
session: remove old NoRegister API
912ef2a
config: add no register config
8352e75
config: add example to example config file.
ffc243c
Merge branch 'master' into no-register
YuJuncen 9c49398
session: remove unused type
48003e7
Merge branch 'no-register' of https://github.com/YuJuncen/tidb into n…
cffa03b
*: rename NoRegister to SkipRegisterToDashboard
c8e2d61
Merge branch 'master' into no-register
YuJuncen a9bd073
Merge branch 'master' into no-register
YuJuncen 08ea547
Merge branch 'master' into no-register
YuJuncen 31541d3
Merge branch 'master' into no-register
YuJuncen 0f8077b
Merge branch 'master' into no-register
YuJuncen 82f3f9d
Merge branch 'master' into no-register
crazycs520 bf7f3e4
Merge branch 'master' into no-register
crazycs520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also disables the DDL syncer, will it cause problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems
InfoSyncer
won't do things about DDL... Is there something I ignored...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how BR uses the DDL structure. If BR uses
InitWithNoRegister
to new a DDL, then the DDL also will campaign DDL owner, but it will make load schema slower thenInit
withInfoSyncer
. Is it OK?