Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add no register API for using TiDB as a library #17513
session: add no register API for using TiDB as a library #17513
Changes from 10 commits
1dd3c2c
1c3280a
e3010e8
0179b99
58977ab
ee8aa92
90c3b95
912ef2a
8352e75
ffc243c
9c49398
48003e7
cffa03b
c8e2d61
a9bd073
08ea547
31541d3
0f8077b
82f3f9d
bf7f3e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better to use
config.GetGlobalConfig().NoRegister
as a argument toGlobalInfoSyncerInit
. It is best to reduce the strong correlation between internal objects andconfig.GetGlobalConfig()
.