ddl: fix parallel execution of "drop DB" and other DDL issue #17566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #17566 +/- ##
===========================================
Coverage 79.4684% 79.4684%
===========================================
Files 520 520
Lines 140204 140204
===========================================
Hits 111418 111418
Misses 19805 19805
Partials 8981 8981 |
AilinKid
added
status/LGT2
crazycs520
approved these changes
Jun 3, 2020
|
/run-all-tests |
zimulala
added
status/LGT3
zimulala
added
the
status/can-merge
|
/run-all-tests |
|
@zimulala merge failed. |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17657 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17658 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17659 |
bb7133
pushed a commit
that referenced
this pull request
Jun 4, 2020
bb7133
pushed a commit
that referenced
this pull request
Jun 4, 2020
zimulala
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17565
Problem Summary:
Parallel execution of "drop database" and other DDL (such as "alter database") may cause panic.
Because we don't check the return value in
GetDatabasein the background.What is changed and how it works?
What's Changed:
How it Works:
After executing
GetDatabase, we need to check whether the return value is nil.Related changes
Check List
Tests
Side effects
Release note