Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix alter-user with hash string (#17640) #17644

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 3, 2020

cherry-pick #17640 to release-3.0


Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #17639

Problem Summary: fix alter user with hash string, which will encode the hash string again.

What is changed and how it works?

What's Changed: judge whether the auth_string is hash string.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • executor: fix alter user with hash string

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 3, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0-cherry-pick labels Jun 3, 2020
@sre-bot sre-bot added this to the v3.0.15 milestone Jun 3, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix CI

Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
Copy link
Contributor

AilinKid commented Jun 4, 2020

/run-all-tests

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/LGT2 Indicates that a PR has LGTM 2. status/all-tests-passed status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@bb7133 bb7133 merged commit 3d4764a into pingcap:release-3.0 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants