Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor/inspect: add config check for storage.block-cache.capacity of TiKV config (#15985) #17671

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

crazycs520
Copy link
Contributor

cherry-pick #15985

What problem does this PR solve?

Add config check for storage.block-cache.capacity of TiKV config. If the total storage.block-cache.capacity more than the system 45% total memory, we should report a warning.

mysql>select * from `INSPECTION_RESULT` where rule='config' and item='storage.block-cache.capacity';
+--------+------------------------------+------+-------------+-------------+---------------+----------+---------------------------------------------------------------------------------------------------------------------------------------+
| RULE   | ITEM                         | TYPE |   INSTANCE  | VALUE       | REFERENCE     | SEVERITY | DETAILS                                                                                                                               |
+--------+------------------------------+------+-------------+-------------+---------------+----------+---------------------------------------------------------------------------------------------------------------------------------------+
| config | storage.block-cache.capacity | tikv | 172.16.5.40 | 60707443507 | < 60707443507 | warning  | There are 4 TiKV server in 172.16.5.40 node, the total 'storage.block-cache.capacity' of TiKV is more than (0.45 * total node memory) |
+--------+------------------------------+------+-------------+-------------+---------------+----------+---------------------------------------------------------------------------------------------------------------------------------------+

What is changed and how it works?

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • Add config check for storage.block-cache.capacity of TiKV config.

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-common-test

@crazycs520 crazycs520 added this to the v4.0.1 milestone Jun 5, 2020
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/rebuild

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 7e0b3c7 into pingcap:release-4.0 Jun 5, 2020
@crazycs520 crazycs520 deleted the 15985-4.0 branch June 5, 2020 02:29
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants