executor/inspect: Add a status_address of inspection_result table…
#17695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to indicate the `status address`. (pingcap#15589)
|
/run-all-tests |
lonng
approved these changes
Jun 5, 2020
|
/merge |
|
Sorry @lonng, you don't have permission to trigger auto merge event on this branch. |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 crazycs520@gmail.com
cherry-pick #15589
Fix pingcap/tidb-dashboard#586
What problem does this PR solve?
Before this PR, the
instancevalue ofinspection_resultis wrong. The value in some row isgrpc service address, such as127.0.0.1:4000, the value in some row isstatus address, such as127.0.0.1:10080.instancevalue.status_addressofinspection_resulttable to indicate thestatus address.Why add a
status_address?Because some diagnose rule such as
server down, we can only get thestatus addressfrom Prometheus.Check List
Tests
Side effects
Release note
status_addressofinspection_resulttable to indicate thestatus address.