-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privileges: support require SAN
(#17539)
#17698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
security
Everything related with security
status/PTAL
type/4.0-cherry-pick
labels
Jun 5, 2020
lysu
added
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
Jun 5, 2020
lysu
removed
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
Jun 5, 2020
jackysp
reviewed
Jun 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imtbkcat
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jun 5, 2020
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
security
Everything related with security
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17539 to release-4.0
What problem does this PR solve?
Issue Number: close #14759
Problem Summary:
see more in issue link
What is changed and how it works?
What's Changed:
require SAN
clause to maintain addition priv infoRelated changes
pingcap/docs
/pingcap/docs-cn
: addrequire SAN
to certificate authentication docs docs-cn#3429Check List
Tests
Side effects
Release note
This change is