table: check valid UTF8 value for UTF8 column #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to check if the input data is valid UTF8 string if the column charset is UTF8, Otherwise, it may cause more serious error in the future, and hard to fix.
|
Will this PR hurt performance? |
|
@shenli Yes when we insert or update utf8 column, but that's something we have to pay.
|
|
LGTM |
shenli
reviewed
Oct 13, 2016
| @@ -212,6 +213,9 @@ func (t *Table) UpdateRecord(ctx context.Context, h int64, oldData []types.Datum | |||
| } | |||
| currentData[i] = defaultVal | |||
| } | |||
| if col.Charset == "utf8" && !utf8.Valid(currentData[i].GetBytes()) { | |||
There was a problem hiding this comment.
Only String types use 'utf8' charset.
|
@zimulala PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to check if the input data is valid UTF8 string if the column charset is UTF8,
Otherwise, it may cause more serious error in the future, and hard to fix.
This prevents future issue like #1808