-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: fix primary selection when delete-your-writes (#18244) #18250
tikv: fix primary selection when delete-your-writes (#18244) #18250
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jackysp,Thanks for you review. |
/run-all-tests |
LGTM |
@coocood,Thanks for you review. |
/run-sqllogic-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@youjiali1995,Thanks for you review. |
@coocood, Thanks for your review, however we are sorry that your vote won't be count. You already give a LGTM to this PR |
/merge |
Sorry @coocood, you don't have permission to trigger auto merge event on this branch. |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-integration-copr-test |
cherry-pick #18244 to release-4.0
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
prewrite
request #9127 introduce addition useless but sometime wrong DEL mutation for delete-your-writesso it will cause read/write inconsistent result when meet lock that point to a primary key has be insert/delete in own txn.
https://github.com/pingcap/tidb/pull/18244/files#diff-d11e207d2529a00e79d72b84ae5172caR722 will fail and read nothing to reproduce it in 2pc test case level.
What is changed and how it works?
What's Changed, How it Works:
choose first key didn't be delete by itself as primary key.
Related changes
Check List
Tests
Side effects
Release note
This change is