Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: resolveFromPlan when tbl.col in havingClause (#18349) #18432

Merged
merged 3 commits into from
Jul 24, 2020
Merged

planner: resolveFromPlan when tbl.col in havingClause (#18349) #18432

merged 3 commits into from
Jul 24, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18349 to release-3.0

What problem does this PR solve?

Issue Number: close #18384

Problem Summary:

What is changed and how it works?

What's Changed:
For SQL like select a+1 from t having t.a, we need to resolve it from the plan and select fields both.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

  • Fix unknown column error for sql like select a from t having t.a

@XuHuaiyu @ti-srebot
cherry pick pingcap#18349 to release-3.0
646a01b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 8, 2020
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Jul 8, 2020
@ti-srebot ti-srebot added this to the v3.0.16 milestone Jul 8, 2020
@qw4990 qw4990 modified the milestones: v3.0.16, v3.0.17 Jul 10, 2020
qw4990
qw4990 reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020
@XuHuaiyu
Copy link
Contributor

/run-all-tests

winoros
winoros approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2020
@XuHuaiyu XuHuaiyu changed the title planner: resolveFromPlan when tblName.colName exists in having clause (#18349) planner: resolveFromPlan when tbl.col in havingClause (#18349) Jul 24, 2020
@XuHuaiyu XuHuaiyu merged commit f048fc7 into pingcap:release-3.0 Jul 24, 2020
@XuHuaiyu XuHuaiyu deleted the release-3.0-62979f69a7f4 branch July 24, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@winoros winoros winoros approved these changes

Assignees

@XuHuaiyu XuHuaiyu

Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @XuHuaiyu @qw4990 @winoros