executor: return error when recover indexHash/MergeJoin worker #18509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
reviewed
Jul 13, 2020
| @@ -189,7 +190,9 @@ func (e *IndexNestedLoopHashJoin) startWorkers(ctx context.Context) { | |||
|
|
|||
| func (e *IndexNestedLoopHashJoin) finishJoinWorkers(r interface{}) { | |||
| if r != nil { | |||
| logutil.BgLogger().Error("IndexNestedLoopHashJoin failed", zap.Error(errors.Errorf("%v", r))) | |||
| e.resultCh <- &indexHashJoinResult{ | |||
There was a problem hiding this comment.
Could you take a glance that if we have similar problems in other executors?
|
/rebuild |
XuHuaiyu
changed the title
|
/run-all-tests |
|
/run-integration-copr-test |
ti-srebot
approved these changes
Jul 14, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-unit-test |
XuHuaiyu
changed the title
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18527 |
ti-srebot
added a commit
that referenced
this pull request
Jul 14, 2020
… (#18527) Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18070
Problem Summary:
What is changed and how it works?
What's Changed:
return the OOM error when indexHashJoin worker panics
How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note