Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Uncomment join test #18697

Merged
merged 3 commits into from Aug 25, 2020
Merged

executor: Uncomment join test #18697

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e78b207
executor: Uncomment join test
Jul 21, 2020
282230d
Merge branch 'master' into fix-11895
Jul 21, 2020
3f976ef
Merge branch 'master' into fix-11895
ti-srebot Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions executor/join_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ func (s *testSuiteJoin2) TestJoinCast(c *C) {
result = tk.MustQuery("select * from t a , t1 b where (a.c1, a.c2) = (b.c1, b.c2);")
result.Check(testkit.Rows("1 2 1 2"))

/* Enable & fix this test after https://github.com/pingcap/tidb/issues/11895 is fixed.
/* Issue 11895 */
tk.MustExec("drop table if exists t;")
tk.MustExec("drop table if exists t1;")
tk.MustExec("create table t(c1 bigint unsigned);")
Expand All @@ -411,7 +411,6 @@ func (s *testSuiteJoin2) TestJoinCast(c *C) {
tk.MustExec("insert into t1 value(-1);")
result = tk.MustQuery("select * from t, t1 where t.c1 = t1.c1;")
c.Check(len(result.Rows()), Equals, 1)
*/

/* https://github.com/pingcap/tidb/issues/11896
tk.MustExec("drop table if exists t;")
Expand Down